Add configurable s3Key as an optional parameter #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adam-aws
previously approved these changes
Feb 23, 2021
eddy-aws
reviewed
Feb 24, 2021
| * @return a pointer that must be used to retrieve the original payload later. | ||
| * @throws SdkClientException If any internal errors are encountered on the client side while | ||
| * attempting to make the request or handle the response. For example | ||
| * if a network connection is not available. | ||
| * @throws S3Exception If an error response is returned by actual PayloadStore indicating | ||
| * either a problem with the data in the request, or a server side issue. | ||
| */ | ||
| String storeOriginalPayload(String payload); | ||
| String storeOriginalPayload(String payload, String... optional); |
There was a problem hiding this comment.
Please create a new method that takes a custom s3Key parameter.
adam-aws
approved these changes
Feb 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to issue #11
Description of changes:
In this pull request, I added an optional parameter to the
PayloadStore.storeOriginalPayload()function, that is to allow consumers to pass custom value for thes3Key.While Java does not support optional parameters, some workarounds are suggested by the community here, from which I have chosen to use Varargs to maintain backward compatibility.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.