Code cleanup and PSR-2 compatibility #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cleanup the code and follow PSR-2 guidelines
update readme with markdown codeblock syntax and typehinting aswell as making it non Laravel 5 specific.
|
This doesn't change functionality right3? So why is a tag needed? |
|
No it doesn't change functionality but the readme sugests installing v0.3.0. This tag does not exist yet and thereby it installs dev-master since the branch is defined as 0.3-dev in the composer json. If there are changes in functionality to be made in the master branch this can cause conflicts on production environments using the suggested 0.3.* version. |
|
I just saw that the latest functionality changes are tagged as 0.2.1. Maybe make that the suggested version in the readme or remove versioning from the require command in the readme in total? |
|
Yeah we should just remove the version there |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup the code to comply with the more modern best practices.
And a small request to add a 0.3.0 tag or release 1.0.0 since its bad to use an adoption of the master branch 😅