update cmake files in preparation for header and ICD loader updates #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are updates in flight for the headers and the ICD loader that require corresponding updates to the extension loader. This change still works with older headers and ICD loaders, but will also work with the updates in flight.
bashbaug
force-pushed
the
prep-for-header-updates
branch
from
20a5105 to
d572ed4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
This updates the extension loader for in-flight changes to the headers and the ICD loader, see:
The main change was to switch to the
OpenCL::OpenCLtarget vs. usingOpenCL_INCLUDE_DIRSandOpenCL_LIBRARIES. This requires CMake 3.7, but CMake 3.7 is fairly pervasive by now and most projects have moved well beyond it (e.g. LLVM).Testing Done
Tested both with and without the upcoming headers changes, via this project and via SimpleOpenCLSamples.