Skip to content

add ifdefs to support building the extension loader with older headers #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 20, 2021

Conversation

bashbaug
Copy link
Owner

Fixes #7

Description of Changes

Adds ifdefs to the extension loader itself so it will build with older headers that do not include all extensions in the XML file.

When older headers are used a message will be emitted indicating that a define for an extension was not found, but the build will continue.

Testing Done

Commented out header files and verified that the extension loader will still build.

@bashbaug
Copy link
Owner Author

The message in the CI builds for the POCL extension is expected because this extension is not in the upstream headers (yet).

@bashbaug bashbaug merged commit 36985c1 into main Oct 20, 2021
@bashbaug bashbaug deleted the support-older-headers branch October 20, 2021 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support older headers without some extensions
1 participant