Split SDK out into it's own project #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bganapa
reviewed
Aug 22, 2018
| @@ -1,9 +1,9 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
| <packages> | |||
| <package id="Microsoft.Azure.KeyVault.Core" version="1.0.0" targetFramework="net45" /> | |||
| <package id="Microsoft.Data.Edm" version="5.8.2" targetFramework="net452" /> | |||
bganapa
reviewed
Aug 22, 2018
| @@ -52,10 +52,6 @@ | |||
| <HintPath>..\..\..\..\packages\Microsoft.Azure.KeyVault.Core.1.0.0\lib\net40\Microsoft.Azure.KeyVault.Core.dll</HintPath> | |||
| <Private>True</Private> | |||
| </Reference> | |||
| <!-- <Reference Include="Microsoft.Azure.Management.Storage, Version=6.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL"> | |||
There was a problem hiding this comment.
lest keep the commented out SDK reference, so that we could easily remember what we copied here
There was a problem hiding this comment.
We didn't copy anything, this was never released remember?
There was a problem hiding this comment.
That was network module.. this one we copied and modified for common runtime changes
There was a problem hiding this comment.
What do you mean? We have a "Generated" directory. Are you saying we did release this specific C# SDK for storage?
There was a problem hiding this comment.
Yes, that version is not compatible with common runtime client libraries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.