Skip to content

Add new API call get_block_status #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 22, 2022
Merged

Add new API call get_block_status #19

merged 1 commit into from
Oct 22, 2022

Conversation

gcomte
Copy link
Contributor

@gcomte gcomte commented Oct 14, 2022

No description provided.

@gcomte gcomte force-pushed the feature/get_block_status branch from 76c47ff to 1c85e07 Compare October 14, 2022 10:37
@coveralls
Copy link

coveralls commented Oct 14, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 3282803591

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 49 of 52 (94.23%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.0%) to 78.894%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/blocking.rs 7 10 70.0%
Totals Coverage Status
Change from base Build 3282065358: 1.0%
Covered Lines: 699
Relevant Lines: 886
💛 - Coveralls

@gcomte gcomte force-pushed the feature/get_block_status branch from 1c85e07 to 0378825 Compare October 14, 2022 11:22
@vladimirfomene
Copy link
Contributor

vladimirfomene commented Oct 19, 2022 •
edited
Loading

@gcomte can you fix the code coverage error?

@gcomte gcomte force-pushed the feature/get_block_status branch from 0378825 to 6a9f76f Compare October 19, 2022 14:59
@gcomte gcomte force-pushed the feature/get_block_status branch from 6a9f76f to 5fbabb8 Compare October 19, 2022 15:14
@gcomte
Copy link
Contributor Author

gcomte commented Oct 19, 2022

@gcomte can you fix the code coverage error?

Oh I'm sorry. Issue is fixed now.

vladimirfomene
vladimirfomene approved these changes Oct 21, 2022
View reviewed changes
Copy link
Contributor

@vladimirfomene vladimirfomene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ACK

notmandatory
notmandatory approved these changes Oct 22, 2022
View reviewed changes
Copy link
Member

@notmandatory notmandatory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 5fbabb8

@notmandatory notmandatory merged commit 8c93e0d into bitcoindevkit:master Oct 22, 2022
@notmandatory notmandatory added this to the Release 0.2.0 milestone Oct 22, 2022
@gcomte gcomte deleted the feature/get_block_status branch October 25, 2022 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notmandatory notmandatory notmandatory approved these changes

@vladimirfomene vladimirfomene vladimirfomene approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 0.2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@gcomte @coveralls @vladimirfomene @notmandatory