Skip to content

Fix deprecation version of get_header #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

tnull
Copy link
Contributor

@tnull tnull commented Oct 25, 2022

In #17, we deprecated get_header and assumed the next version would be 0.1.2, but it turned out to be 0.2.

@coveralls
Copy link

coveralls commented Oct 25, 2022

Pull Request Test Coverage Report for Build 3321372934

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 78.894%

Totals Coverage Status
Change from base Build 3313936566: 0.0%
Covered Lines: 699
Relevant Lines: 886

💛 - Coveralls

We assumed the next version would be 0.1.2, but it turned out to be 0.2.
@tnull tnull force-pushed the 2022-10-fix-deprecation-version branch from c506447 to 3a93ee5 Compare October 25, 2022 13:37
@tnull tnull changed the title Fix deprecation version of get_header Fix deprecation version of get_height Oct 25, 2022
@tnull tnull changed the title Fix deprecation version of get_height Fix deprecation version of get_header Oct 26, 2022
Copy link
Contributor

@vladimirfomene vladimirfomene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review ACK. This makes sense to me.

@notmandatory notmandatory merged commit 18b7d9f into bitcoindevkit:master Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants