Skip to content

bugfix one example of 010-bash-conditionals #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 27, 2024

Conversation

nknanfeng
Copy link
Contributor

What type of PR is this? (check all applicable)

  • 🐛 Bug Fix

Description

In this example, if we want to express "In this example we want to make sure that the user is neither the admin user nor the root user to ensure the script is incapable of causing too much damage," should we use && instead of ||?

Related Tickets & Documents

Added to documentation?

  • 🙅 no documentation needed

[optional] What gif best describes this PR or how it makes you feel?

Copy link

what-the-diff bot commented Aug 29, 2024

PR Summary

  • Updated Logical Operator in Conditional Statement
    The logical operator within a specific decision-making section of the code has been changed from 'or' to 'and'. This means that now both conditions have to be met, not just either of them, for the code to execute a certain operation. This modification will enhance the accuracy and reliability of the software by reducing the chances of unwanted behavior.

@nknanfeng nknanfeng marked this pull request as ready for review August 29, 2024 02:19
Copy link
Owner

@bobbyiliev bobbyiliev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@bobbyiliev bobbyiliev merged commit a780988 into bobbyiliev:main Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants