Skip to content

Commit eacde9a

Browse files
committed
fixup: Handle resource arrays
1 parent 005e4b7 commit eacde9a

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

clang/lib/Sema/SemaHLSL.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3285,7 +3285,7 @@ void SemaHLSL::processExplicitBindingsOnDecl(VarDecl *VD) {
32853285
}
32863286
}
32873287

3288-
if (!HasBinding && VD->getType()->isHLSLResourceRecord())
3288+
if (!HasBinding && isResourceRecordTypeOrArrayOf(VD))
32893289
SemaRef.Diag(VD->getLocation(), diag::warn_hlsl_implicit_binding);
32903290
}
32913291

clang/test/SemaHLSL/resource_binding_implicit.hlsl

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,3 +32,9 @@ struct CustomSRV {
3232
};
3333
// expected-warning@+1 {{resource has implicit register binding}}
3434
CustomSRV g;
35+
36+
// expected-warning@+1 {{resource has implicit register binding}}
37+
RWBuffer<float> h[10];
38+
39+
// No warning - explicit binding.
40+
RWBuffer<float> hh[100] : register(u4);

0 commit comments

Comments
 (0)