Skip to content

feat: add support for 'import' content type in Proxmox file resources #1983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Vaneixus
Copy link

@Vaneixus Vaneixus commented Jun 6, 2025

Signed-off-by: Marco Attia [email protected]

Contributor's Note

  • I have added / updated documentation in /docs for any user-facing features or additions.
  • I have added / updated acceptance tests in /fwprovider/tests for any new or updated resources / data sources.
  • I have ran make example to verify that the change works as expected.

Proof of Work

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #1913

@Vaneixus Vaneixus marked this pull request as draft June 6, 2025 15:53
@Vaneixus
Copy link
Author

Vaneixus commented Jun 6, 2025

It's not ready yet. but I am open to any comments thus far.

@Vaneixus
Copy link
Author

Vaneixus commented Jun 6, 2025

One of the things I need to check and implement is maintain Backwards compat with Proxmox version < 8.4, since those will still need to use the SSH method.

@Vaneixus Vaneixus force-pushed the 1913_Import_Disks branch from 3c31593 to 22605ac Compare June 10, 2025 14:24
@Vaneixus Vaneixus force-pushed the 1913_Import_Disks branch from 22605ac to 15d9a12 Compare June 10, 2025 14:28
@Vaneixus
Copy link
Author

I force-pushed to sign the commits since I do not have access to my signing key in the devcontainer. nothing has changed, except, well, a new commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant