[SDK-3090] Remote screenshotter service support #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
oh, no, it just can't run coverage because it doesn't have the secrets the base repo had |
|
Looks like it got ported over cleanly to me |
Zaxcoding
approved these changes
Oct 28, 2022
|
i think i have to merge it for github to pick up the workflow revision, all but the step that requires codeclimate are green |
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an implementation of a command similar to the
matchRemoteImageSnapshotcommand from IAM-76 / https://github.com/Appboy/platform/pull/46841 - rewritten on a fork of a more actively maintained, ts-based, image comparison cypress plugin (with a comparison/baseline-updating UI!). It's working for me locally integrated into platform. I'm not able to commit my platform side yet due to some tsconfig issues that I hope running the CI workflow (which is in github) on this repo will allow me to repair.