Skip to content

Fix Specs Array Case for Enforce_Settings MAC #762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 13, 2023

Conversation

hariharanbrowserstack
Copy link
Collaborator

Description:

  • When SpecPattern value passed as an array, it fails only for mac. This is to fix it.
  • Before - from CLI: video=true,videoUploadOnPasses=true,specPattern="["cypress/e2e/1-getting-started/basic.cy.js","cypress/e2e/1-getting-started/skip.cy.js","cypress/e2e/1-getting-started/todo1.spec.js","cypress/e2e/1-getting-started/pending.cy.js"]"
  • Before - in Rails it parsed to: --config 'video=true,videoUploadOnPasses=true,specPattern=\"[\"cypress/e2e/1-getting-started/basic.cy.js\",\"cypress/e2e/1-getting-started/skip.cy.js\",\"cypress/e2e/1-getting-started/todo1.spec.js\",\"cypress/e2e/1-getting-started/pending.cy.js\"]\"'
  • This fails due to the escaped double quotes which it tries to search as string.
  • Corrected to: video=true,videoUploadOnPasses=true,specPattern=["cypress/e2e/1-getting-started/basic.cy.js","cypress/e2e/1-getting-started/skip.cy.js","cypress/e2e/1-getting-started/todo1.spec.js","cypress/e2e/1-getting-started/pending.cy.js"]
  • Rails: 'video=true,videoUploadOnPasses=true,specPattern=[\"cypress/e2e/1-getting-started/basic.cy.js\",\"cypress/e2e/1-getting-started/skip.cy.js\",\"cypress/e2e/1-getting-started/todo1.spec.js\",\"cypress/e2e/1-getting-started/pending.cy.js\"]'

@hariharanbrowserstack hariharanbrowserstack requested a review from a team as a code owner December 11, 2023 12:50
@pranavj1001 pranavj1001 merged commit 5d419bc into master Dec 13, 2023
@pranavj1001 pranavj1001 mentioned this pull request Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants