update browserstack local with new commands #24
Conversation
|
Updating the tunnel options to use the format specified in https://www.browserstack.com/local-testing. Also added parallelRuns option. |
|
@vedharish Please merge and release with a major version bump :) |
|
Awesome, thanks @Blackbaud-PatrickOFriel ! |
There was a problem hiding this comment.
Hey @Blackbaud-PatrickOFriel ,
Sorry for being late on this. Need just one clarification/review. The PR looks awesome, will merge after this.
Thanks.
| if(value) | ||
| this.logfile = value; | ||
| break; | ||
|
|
||
| case 'binarypath': |
There was a problem hiding this comment.
Any reason to remove this option? This option allows us to customize the BrowserStackLocal binary path ( the binary must be present at the path and won't be downloaded ).
We were using this for other language bindings as well.
There was a problem hiding this comment.
The only reason I removed that was because I didn't see binarypath listed as an option here, I assumed they removed that option. But I have no knowledge of the inner workings of the Browserstack tunnel, just going straight off of their documentation, so maybe that functionality still exists and it is undocumented.
There was a problem hiding this comment.
@Blackbaud-PatrickOFriel binarypath is an option provided by this wrapper not the actual binary. Can you please add it back in the PR?
There was a problem hiding this comment.
Ah gotcha, definitely can do
|
Thanks @Blackbaud-PatrickOFriel @AnkurGel |
No description provided.