Skip to content

Key issue in options #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 9, 2016
Merged

Key issue in options #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9393899
key in options fix
tr4n2uil May 9, 2016
2983bb4
bumped up version
tr4n2uil May 9, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion browserstack/local.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,16 +26,21 @@ def _generate_cmd(self):
def start(self, **kwargs):
self.options = kwargs

if 'key' in self.options:
self.key = self.options['key']
del self.options['key']

if 'binarypath' in self.options:
self.binary_path = binary_path
del self.options['binarypath']
else:
self.binary_path = LocalBinary().get_binary()

if 'logfile' in self.options:
self.local_logfile_path = self.options['logfile']
del self.options['logfile']

if "onlyCommand" in kwargs and kwargs["onlyCommand"]:
if "onlyCommand" in kwargs and kwargs["onlyCommand"]:
return

self.proc = subprocess.Popen(self._generate_cmd(), stdout=subprocess.PIPE)
Expand Down
4 changes: 2 additions & 2 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,12 @@
setup(
name = 'browserstack-local',
packages = ['browserstack'],
version = '0.3.0',
version = '0.3.1',
description = 'Python bindings for Browserstack Local',
author = 'BrowserStack',
author_email = '[email protected]',
url = 'https://github.com/browserstack/browserstack-local-python',
download_url = 'https://github.com/browserstack/browserstack-local-python/archive/v0.1.0.tar.gz',
download_url = 'https://github.com/browserstack/browserstack-local-python/archive/master.zip',
keywords = ['BrowserStack', 'Local', 'selenium', 'testing'],
classifiers = [],
)
Expand Down