Skip to content

Add context manager to Local #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 16, 2020
Merged

Add context manager to Local #28

merged 1 commit into from
Dec 16, 2020

Conversation

m4rc1e
Copy link
Contributor

@m4rc1e m4rc1e commented Dec 4, 2020

This PR will add the ability to use the with statement for Local e.g

from browserstack.local import Local

with Local(key=os.environ["BROWSERSTACK_ACCESS_KEY"]) as bs_local:
    print(bs_local.isRunning())

yashLadha
yashLadha approved these changes Dec 11, 2020
View reviewed changes
Copy link
Contributor

@yashLadha yashLadha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@francisf francisf merged commit 2b85ae3 into browserstack:master Dec 16, 2020
@m4rc1e
Copy link
Contributor Author

m4rc1e commented Dec 16, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yashLadha yashLadha yashLadha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@m4rc1e @yashLadha @francisf