Skip to content

[active-active] Add active cluster selection policy to workflow start #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

taylanisikdemir
Copy link
Member

@taylanisikdemir taylanisikdemir commented Jun 4, 2025

Summary

[Brief summary of the change, including the rationale and intended effect]
Active cluster selection policy will be applicable to active-active domains. More details on active-active mode can be found here.

Type of Change

  • Add new API(s)
  • Add new data type(s)
  • Add new field(s) to existing data type
  • Remove field(s) from data type
  • Remove data type(s)
  • Remove API(s)
  • Other (please provide detailed description)

Data Effect

  • Does it change the data stored in database?

Detailed Description

[In-depth description of the changes made to the IDL, specifying new fields, removed fields, or modified data structures]
There will be a new field in workflow execution info. This is mostly for informational purposes.
There is going to be a new row type to store the policy for wf-runid pair which will be used by frontend to determine active region/cluster to forward accordingly.

Impact Analysis

  • Backward Compatibility: [Analysis of backward compatibility]
    Changes are backward compatible. No impact until server starts using these.
  • Forward Compatibility: [Analysis of forward compatibility]

Testing Plan

  • Unit Tests: [Do we have unit test covering the change?]
  • Persistence Tests: [If the change is related to a data type which is persisted, do we have persistence tests covering the change?]
  • Integration Tests: [Do we have integration test covering the change?]
  • Compatibility Tests: [Have we done tests to test the backward and forward compatibility?]

Rollout Plan

  • What is the rollout plan?
  • Does the order of deployment matter?
  • Is it safe to rollback? Does the order of rollback matter?
  • Is there a kill switch to mitigate the impact immediately?

Copy link
Member

@timl3136 timl3136 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should fix the enum naming before merging

@timl3136 timl3136 dismissed their stale review June 11, 2025 18:20

The requested change is minor and won't break system

@taylanisikdemir taylanisikdemir merged commit 65a2b63 into cadence-workflow:master Jun 11, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants