feat: Ignore args required for strong typing correctness #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In our codebase, we have this pattern:
```js
animate = (_: ?number) => {};
```
That triggers the unused-vars warning due to the argument being unused. In this instance, the argument is there to pass strong-type checks, and we have a code style guideline that uses prepending of underscore to signify that the argument (or catch variable) is unused.
This PR adds a narrowing and widening of the no-unused-vars rule:
1. to ignore unused arguments that begin with an underscore (a narrowing)
2. to report unused caught exceptions that don't begin with an underscore (a widening since unused caught errors was previously OFF by default)
thymikee
changed the title
|
Based on 2. we should release a major version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In our codebase, we have this pattern:
That triggers the unused-vars warning due to the argument being unused. In this instance, the argument is there to pass strong-type checks, and we have a code style guideline that uses prepending of underscore to signify that the argument (or catch variable) is unused.
This PR adds a narrowing and widening of the no-unused-vars rule:
Test plan
Added code examples to test JS file, verified no errors.