refactor: use install_modules_dependencies method only if react native version >=0.71.0 #358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hod to depend on React Native core changes
satya164
reviewed
Feb 24, 2023
|
Hey @satya164, This method contains all the needed IOS dependencies (same as the current that we have now) with supporting old and new architecture, the purpose of adding it is to simplify the process of migrating to a new React Native version, by depending on React Native changes rather than duplicate same code, this method exists starting from v0.71.0. Here is the full implementation: https://github.com/facebook/react-native/blob/febf6b7f33fdb4904669f99d795eba4c0f95d7bf/scripts/cocoapods/new_architecture.rb#L79 |
… and keep supporting older versions <0.71.0
ykhateeb
force-pushed
the
use-install_modules_dependencies-in-ios-podspec
branch
from
44bf0d9 to
380e8ea
Compare
|
@satya164 Could you please check it now? |
ykhateeb
changed the title
ykhateeb
changed the title
ykhateeb
changed the title
ykhateeb
changed the title
satya164
force-pushed
the
main
branch
6 times, most recently
from
99cfbff to
0775dc9
Compare
ykhateeb
changed the title
satya164
pushed a commit
that referenced
this pull request
May 16, 2024
<!-- Please provide enough information so that others can review your pull request. --> <!-- Keep pull requests small and focused on a single change. --> ### Summary <!-- What existing problem does the pull request solve? Can you solve the issue with a different approach? --> After #358 identation become shifted which makes code hard to read and could lead to bugs. For example I was placing package dependencies inside `if/else` block, right after `s.dependency "React-Core"` see | before | after | |--------|--------| | <img width="1624" alt="image" src="https://github.com/callstack/react-native-builder-bob/assets/1577804/65a6b479-3e76-4170-b874-b5635b6a5401"> | <img width="1624" alt="image" src="https://github.com/callstack/react-native-builder-bob/assets/1577804/5e3862e7-e6d9-48da-9efd-5c3e5f611749"> | ### Test plan <!-- List the steps with which we can test this change. Provide screenshots if this changes anything visual. --> Purely aesthetic changes, so nothing to break
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request replaces all the inline IOS dependencies in podspec and uses
install_modules_dependenciesmethod to depend on React Native core changes.