fix: add rn-config so CLI doesn't try to link it #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A root podspec file should be published with package so that pod install doesn't complain when installing projects with bob. I add it here but not quite sure where it should be in order to be published at the root of package. Also added homepage property in package.json as required by podspec.
|
Hmm, why would you need a podspec? This is not a native module. Seems like a bug in CLI? |
|
Hey! It seems like CLI is detecting Bob as native library. It should be possible to disable autolinking of this package by creating a |
|
react-native.config.js file added as per @thymikee 's suggestion |
thymikee
approved these changes
Apr 6, 2020
satya164
approved these changes
May 6, 2020
satya164
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Executing
currently results in pod complaining no pod spec exists for react-native-bob
This fix tentatively add a react-native-bob.podspec file that should solve this.
Note: this new file should be published at the root of the package. I'm not quite sure how this can be done. Please edit accordingly.
We also add a homepage property in package.json as it's required by standard podspec files
Test Plan
When file manually added to node_module/@react-native-community/bob, executing pod install doesn't complain anymore
What's required for testing (prerequisites)?
Not quite sure how to test before releasing a new version ?
Compatibility
Checklist
README.mdCHANGELOG.mdexample/App.js)