Skip to content

fix: remove unused cmake abiFilters #486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 24, 2023
Merged

fix: remove unused cmake abiFilters #486

merged 1 commit into from
Nov 24, 2023

Conversation

Sunbreak
Copy link
Contributor

Summary

cmake.abiFilters specifies the Application Binary Interfaces (ABI) that Gradle should build outputs for. The ABIs that Gradle packages into your APK are determined by android.defaultConfig.ndk.abiFilter link

  • Support for C++ module was introduced at 6588c5c three years ago
  • React Native application template instroduced reactNativeArchitectures since facebook/react-native@0f39a10 two years ago

Test plan

None

satya164
satya164 approved these changes Nov 24, 2023
View reviewed changes
Copy link
Member

@satya164 satya164 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@satya164 satya164 merged commit 7582485 into callstack:main Nov 24, 2023
@Sunbreak Sunbreak deleted the rm-cmake-abi branch November 28, 2023 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@satya164 satya164 satya164 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sunbreak @satya164