Skip to content

Update ci.yml : Using pod install instead of pod-install #520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 2, 2024
Merged

Update ci.yml : Using pod install instead of pod-install #520

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0e82821
Update ci.yml
Archish27 Jan 30, 2024
b7008c4
chore: remove pod-install from the template
satya164 Feb 2, 2024
5776b99
chore: tweak
satya164 Feb 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/build-templates.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,8 @@ jobs:
if: env.ios_build == 1 && env.turbo_cache_hit_ios != 1 && steps.library-cocoapods-cache.outputs.cache-hit != 'true'
working-directory: ${{ env.work_dir }}
run: |
yarn pod-install example/ios
cd example/ios
pod install
env:
NO_FLIPPER: 1

Expand Down
6 changes: 0 additions & 6 deletions packages/create-react-native-library/src/utils/generateExampleApp.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,10 +47,6 @@ const PACKAGES_TO_ADD_WEB_DEV = {
'babel-loader': '^8.1.0',
};

const PACKAGES_TO_ADD_NATIVE_DEV = {
'pod-install': '^0.1.0',
};

export default async function generateExampleApp({
type,
dest,
Expand Down Expand Up @@ -164,8 +160,6 @@ export default async function generateExampleApp({
});

scripts.web = 'expo start --web';
} else {
Object.assign(devDependencies, PACKAGES_TO_ADD_NATIVE_DEV);
}

await fs.writeJSON(path.join(directory, 'package.json'), pkg, {
Expand Down
3 changes: 2 additions & 1 deletion packages/create-react-native-library/templates/common/$.github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,8 @@ jobs:
- name: Install cocoapods
if: env.turbo_cache_hit != 1 && steps.cocoapods-cache.outputs.cache-hit != 'true'
run: |
yarn pod-install example/ios
cd example/ios
pod install
env:
NO_FLIPPER: 1

Expand Down
3 changes: 0 additions & 3 deletions packages/create-react-native-library/templates/common/$package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,9 +72,6 @@
"eslint-config-prettier": "^8.5.0",
"eslint-plugin-prettier": "^4.0.0",
"jest": "^28.1.1",
<% if (example === 'native') { -%>
"pod-install": "^0.1.0",
<% } -%>
"prettier": "^2.0.5",
"react": "17.0.2",
"react-native": "0.70.0",
Expand Down
4 changes: 3 additions & 1 deletion packages/create-react-native-library/templates/common/CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,9 @@ By default, the example is configured to build with the old architecture. To run
2. For iOS, run:

```sh
RCT_NEW_ARCH_ENABLED=1 yarn pod-install example/ios
cd example/ios
RCT_NEW_ARCH_ENABLED=1 pod install
cd -
yarn example ios
```

Expand Down