Skip to content

chore: use the macOS 13 runner #523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 14 additions & 14 deletions .github/workflows/build-templates.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ jobs:
fail-fast: false
matrix:
os:
- ubuntu
- macos
- ubuntu-latest
- macos-13 # macos latest defaults to macos 12 at the moment.
type:
- module-legacy
- module-mixed
Expand All @@ -37,9 +37,9 @@ jobs:
- kotlin-objc
- kotlin-swift
exclude:
- os: macos
- os: macos-13
language: kotlin-objc
- os: macos
- os: macos-13
language: kotlin-swift
- type: module-new
language: java-swift
Expand All @@ -58,33 +58,33 @@ jobs:
- type: view-mixed
language: kotlin-swift
include:
- os: ubuntu
- os: ubuntu-latest
type: library
language: js
- os: ubuntu
- os: ubuntu-latest
type: module-legacy
language: cpp
- os: ubuntu
- os: ubuntu-latest
type: module-mixed
language: cpp
- os: ubuntu
- os: ubuntu-latest
type: module-new
language: cpp
- os: macos
- os: macos-13
type: module-legacy
language: cpp
- os: macos
- os: macos-13
type: module-mixed
language: cpp
- os: macos
- os: macos-13
type: module-new
language: cpp

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}-${{ matrix.os }}-${{ matrix.type }}-${{ matrix.language }}
cancel-in-progress: true

runs-on: ${{ matrix.os }}-latest
runs-on: ${{ matrix.os }}

steps:
- name: Checkout
Expand Down Expand Up @@ -138,14 +138,14 @@ jobs:
working-directory: ${{ env.work_dir }}
run: |
# Build Android for only some matrices to skip redundant builds
if [[ ${{ matrix.os }} == ubuntu ]]; then
if [[ ${{ matrix.os }} == ubuntu-latest ]]; then
if [[ ${{ matrix.type }} == view-* && ${{ matrix.language }} == *-objc ]] || [[ ${{ matrix.type }} == module-* && ${{ matrix.language }} == *-objc ]] || [[ ${{ matrix.type }} == module-* && ${{ matrix.language }} == cpp ]]; then
echo "android_build=1" >> $GITHUB_ENV
fi
fi

# Build iOS for only some matrices to skip redundant builds
if [[ ${{ matrix.os }} == macos ]]; then
if [[ ${{ matrix.os }} == macos-13 ]]; then
if [[ ${{ matrix.type }} == view-* && ${{ matrix.language }} == java-* ]] || [[ ${{ matrix.type }} == module-* && ${{ matrix.language }} == java-* ]] || [[ ${{ matrix.type }} == module-* && ${{ matrix.language }} == cpp ]]; then
echo "ios_build=1" >> $GITHUB_ENV
fi
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ jobs:
yarn turbo run build:android --cache-dir="${{ env.TURBO_CACHE_DIR }}"

build-ios:
runs-on: macos-latest
runs-on: macos-13
env:
TURBO_CACHE_DIR: .turbo/ios
steps:
Expand Down