Skip to content
This repository was archived by the owner on Sep 20, 2024. It is now read-only.

fix: add an unstyled variant to the c-button validators #459

Merged
merged 2 commits into from
Jul 12, 2021
Merged

fix: add an unstyled variant to the c-button validators #459

merged 2 commits into from
Jul 12, 2021

Conversation

abelnnieva
Copy link
Contributor

Description

Fixes props validator issue with CBotton component, when variant set to “unstyled".

Screenshots (if appropriate):

Captura de pantalla 2021-07-12 a las 23 03 11

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@changeset-bot
Copy link

changeset-bot bot commented Jul 12, 2021 •
edited
Loading

🦋 Changeset detected

Latest commit: 46a353a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@chakra-ui/vue Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jul 12, 2021

@abelnnieva is attempting to deploy a commit to the Chakra UI Team on Vercel.

A member of the Team first needs to authorize it.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 12, 2021 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 46a353a:

Sandbox Source
Chakra UI Vue (0.X) Starter Template Configuration
chakra-ui-nuxt-demo Configuration

@vercel
Copy link

vercel bot commented Jul 12, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

chakra-ui-vue – ./

🔍 Inspect: https://vercel.com/chakra-ui/chakra-ui-vue/9LFGVSJC1qpzu9T5vnEg6aJZmsEZ
✅ Preview: https://chakra-ui-vue-git-fork-abelnnieva-fix-cbutton-480c51-chakra-ui.vercel.app

codebender828
codebender828 previously approved these changes Jul 12, 2021
View reviewed changes
Copy link
Collaborator

@codebender828 codebender828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @abelnnieva . Good catch

@codebender828 codebender828 self-requested a review July 12, 2021 23:47
@codebender828 codebender828 merged commit 9704251 into chakra-ui:develop Jul 12, 2021
@abelnnieva abelnnieva deleted the fix-cbutton-prop-validator branch July 14, 2021 18:56
@codebender828 codebender828 mentioned this pull request Jul 16, 2021
Merged
8 tasks
@codebender828
Copy link
Collaborator

@all-contributors please add @abelnnieva for bugs, code

@allcontributors allcontributors bot mentioned this pull request Jul 16, 2021
Merged
@allcontributors
Copy link
Contributor

@codebender828

I've put up a pull request to add @abelnnieva! 🎉

@github-actions github-actions bot mentioned this pull request Jul 16, 2021
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@codebender828 codebender828 codebender828 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abelnnieva @codebender828