This repository was archived by the owner on Sep 20, 2024. It is now read-only.
fix(menu): allow menu option group to use array prop #503
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The documentation says
CMenuOptionGroup
accepts a string, number, Array as a value of the:value
attribute. However, when the array is passed, a warning is thrown in the console:Invalid prop: type check failed for prop "value". Expected String, Number, got Array
However, the component itself works as expected.
This PR fixes the error and allow the value prop to be passed as an array.
Motivation and Context
Fixes #497
How Has This Been Tested?
I tested with Storybook and the error wasn't displayed on the console when the fix was applied
Types of changes
Checklist: