Skip to content

Fix response handling in authentication #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 17, 2020
Merged

Fix response handling in authentication #36

merged 5 commits into from
Aug 17, 2020

Conversation

avitex
Copy link
Contributor

@avitex avitex commented Aug 12, 2020

Closes #35

  • Auth responses being handled (sasl working now)
  • Useless debug field removed - breaking change
  • More unsolicited messages handled on auth - breaking change
  • Consume mutable authenticators (to support SASL mechs better) - breaking change
  • Improved client debug (buffer formatting was far too long)
  • Fixed clippy warnings

@link2xt
Copy link
Contributor

link2xt commented Aug 15, 2020

It works:

 WARN  repl > src/imap/mod.rs:309: Cannot login as "...yandex....". Please check if the email address and the password are correct. (no response: code: None, info: Some("[AUTHENTICATIONFAILED] AUTHENTICATE invalid credentials or IMAP is disabled sc=..."))

Also connects when IMAP is enabled.

Copy link
Contributor

@dignifiedquire dignifiedquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@dignifiedquire dignifiedquire merged commit 95d3a5f into chatmail:master Aug 17, 2020
@avitex avitex deleted the fix-auth branch August 25, 2020 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Authentication error is ignored when configuring Yandex with OAuth2
3 participants