Command Line report generator

[pbilstein]

Hi chewiebug,

you might be interessted in the cmdline interface capabilities that I have added.
It can generate a csv report based on a gc.log

Kind regards,
Peter

[chewiebug]

Hi Peter,

Thank you very much for your contribution - definitely a feature that
was missing. Please allow me some time to review the code and come back
to you.

Kind regards, Jörg

On 04.06.2012 21:16, Peter wrote:

Hi chewiebug,

you might be interessted in the cmdline interface capabilities that I have added.
It can generate a csv report based on a gc.log

Kind regards,
Peter

You can merge this Pull Request by running:

git pull https://github.com/pbilstein/GCViewer master

Or you can view, comment on it, or merge it online at:

#26

-- Commit Summary --

• added cmdline functionality
• changed readme

-- File Changes --

M README (6)
M pom.xml (2)
A src/main/java/com/tagtraum/perf/gcviewer/Main.java (62)
A src/main/java/com/tagtraum/perf/gcviewer/exp/summary/CsvSummaryExportFormatter.java (21)
A src/main/java/com/tagtraum/perf/gcviewer/exp/summary/ISummaryExportFormatter.java (12)
A src/main/java/com/tagtraum/perf/gcviewer/exp/summary/SummaryExporter.java (301)
A src/main/java/com/tagtraum/perf/gcviewer/util/Formatted.java (37)
M src/main/java/com/tagtraum/perf/gcviewer/util/MemoryFormat.java (15)
A src/main/java/com/tagtraum/perf/gcviewer/util/MemoryFormatNoCommas.java (68)
A src/main/java/com/tagtraum/perf/gcviewer/util/NumberFormatNoCommas.java (73)
M src/main/java/com/tagtraum/perf/gcviewer/util/TimeFormat.java (10)

-- Patch Links --

https://github.com/chewiebug/GCViewer/pull/26.patch
https://github.com/chewiebug/GCViewer/pull/26.diff

---

Reply to this email directly or view it on GitHub:
#26

[pbilstein]

Hi Jörg,

great, if you have any questions feel free to ask me.

Kind regards,
Peter

[pbilstein]

Hi Jörg,

I found out that the number formatter does not work as one would expect. It seems that the original author implemented a comma replacement, without respecting the 3 decimals. Thats somehow confusing.... I think I have to spend some effort into this to create somehow senseful results. I will contact you again, after everything works as ecpected.

Kind regards
Peter

[chewiebug]

Hi Peter,

I have found places in the parser where commas and points receive
special treatment - I don't always see why. In which class is the comma
replacement you are speaking about?

I have looked at the csv that is created with your code. You extract
quite a lot of information - probably about as much as is displayed with
the gui, I like this.

If you change two points, the implemenation would better suit my needs:

1. I'd prefer the output in the csv file to be on one line for one gc
   log (or two: 1st line: column names, 2nd line: values). Like this
   processing with a spreadsheet application afterwards is easy.
2. I'd like to have the possibility to pass more than one file (a whole
   directory) for one run.

What do you think about these two points?

Regards, Jörg

On 12.06.2012 16:56, Peter wrote:

Hi Jörg,

I found out that the number formatter does not work as one would expect. It seems that the original author implemented a comma replacement, without respecting the 3 decimals. Thats somehow confusing.... I think I have to spend some effort into this to create somehow senseful results. I will contact you again, after everything works as ecpected.

Kind regards
Peter

---

Reply to this email directly or view it on GitHub:
#26 (comment)

[chewiebug]

Hi Peter,

Have you found a solution to the problem concerning the number formatter?

Regards, Jörg

[pbilstein]

Hi Jörg,

sorry for not replying for months, I had no time to do further work
on the gcviewer.

About the comma replacement: I haven't changed the original
treatment in the parser. The part I was mentioning was inside the
export code. In this part I decided to use the locale formatting
of the maschine (meaning that a US machine will get the numbers
with decimal separator dot and a German machine with
decimal separator comma in the csv file).

About your two proposals: Currently I'm not planning to realize them,
but thats something I will keep in my backlog.

Basically I used the export to generate an automated summary only,
with information like memory throughput etc. (I use it in some
automated testing scenarios ;-)

Since my changes work quite well now, I will resend you the pull
request. It has no changes on the core functionallity and only adds
the cmd line export. The only additional thing that has changed,
is the introduction of a new Main class, which is already registered
in the manifest. This was necessary to allow gcviewer to run without
an graphical environment when using cmd line mode. The reason is,
that the old main class tried to initialize some awt stuff. After separation
it works in cmd line mode. Old behavior with UI has not changed.

Kind regards
Peter

2012/6/17 chewiebug <
[email protected]

Hi Peter,

I have found places in the parser where commas and points receive
special treatment - I don't always see why. In which class is the comma
replacement you are speaking about?

I have looked at the csv that is created with your code. You extract
quite a lot of information - probably about as much as is displayed with
the gui, I like this.

If you change two points, the implemenation would better suit my needs:

1. I'd prefer the output in the csv file to be on one line for one gc
   log (or two: 1st line: column names, 2nd line: values). Like this
   processing with a spreadsheet application afterwards is easy.
2. I'd like to have the possibility to pass more than one file (a whole
   directory) for one run.

What do you think about these two points?

Regards, Jörg

On 12.06.2012 16:56, Peter wrote:

Hi Jörg,

I found out that the number formatter does not work as one would expect.
It seems that the original author implemented a comma replacement, without
respecting the 3 decimals. Thats somehow confusing.... I think I have to
spend some effort into this to create somehow senseful results. I will
contact you again, after everything works as ecpected.

Kind regards
Peter

---

Reply to this email directly or view it on GitHub:
#26 (comment)

---

Reply to this email directly or view it on GitHub:
#26 (comment)

[chewiebug]

Hi Peter,

Sorry, I am not much faster as well ;-).

Thank you for your pull request. I will pull it in within the next few days.

Best regards, Jörg

Am 30.08.2012 11:32, schrieb Peter:

Hi Jörg,

sorry for not replying for months, I had no time to do further work
on the gcviewer.

About the comma replacement: I haven't changed the original
treatment in the parser. The part I was mentioning was inside the
export code. In this part I decided to use the locale formatting
of the maschine (meaning that a US machine will get the numbers
with decimal separator dot and a German machine with
decimal separator comma in the csv file).

About your two proposals: Currently I'm not planning to realize them,
but thats something I will keep in my backlog.

Basically I used the export to generate an automated summary only,
with information like memory throughput etc. (I use it in some
automated testing scenarios ;-)

Since my changes work quite well now, I will resend you the pull
request. It has no changes on the core functionallity and only adds
the cmd line export. The only additional thing that has changed,
is the introduction of a new Main class, which is already registered
in the manifest. This was necessary to allow gcviewer to run without
an graphical environment when using cmd line mode. The reason is,
that the old main class tried to initialize some awt stuff. After
separation
it works in cmd line mode. Old behavior with UI has not changed.

Kind regards
Peter

2012/6/17 chewiebug <
[email protected]

Hi Peter,

I have found places in the parser where commas and points receive
special treatment - I don't always see why. In which class is the comma
replacement you are speaking about?

I have looked at the csv that is created with your code. You extract
quite a lot of information - probably about as much as is displayed
with
the gui, I like this.

If you change two points, the implemenation would better suit my needs:

1. I'd prefer the output in the csv file to be on one line for one gc
   log (or two: 1st line: column names, 2nd line: values). Like this
   processing with a spreadsheet application afterwards is easy.
2. I'd like to have the possibility to pass more than one file (a whole
   directory) for one run.

What do you think about these two points?

Regards, Jörg

On 12.06.2012 16:56, Peter wrote:

Hi Jörg,

I found out that the number formatter does not work as one would
expect.
It seems that the original author implemented a comma replacement,
without
respecting the 3 decimals. Thats somehow confusing.... I think I
have to
spend some effort into this to create somehow senseful results. I will
contact you again, after everything works as ecpected.

Kind regards
Peter

---

Reply to this email directly or view it on GitHub:
#26 (comment)

---

Reply to this email directly or view it on GitHub:
#26 (comment)

—
Reply to this email directly or view it on GitHub
#26 (comment).