Skip to content

Performance: use clipped polygon to draw lines #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 28, 2012

Conversation

nigelzor
Copy link
Contributor

Filled polygon statistics are only drawn in the currently-visible region. Line statistics can re-use this logic, rather than wastefully drawing to areas scrolled out of view.

When working with large GC log files, this is a major performance improvement.

@ghost ghost assigned chewiebug Nov 28, 2012
@chewiebug chewiebug merged commit f553548 into chewiebug:master Nov 28, 2012
@chewiebug
Copy link
Owner

Hi Neil,

Thank you for contributing this improvement! I found that GCRectanglesRenderer didn't use any clipping logic as well. I have added another fix for that renderer.

By the way: How large are "large" log files for you? How many gc events do they contain?

Regards, Jörg

@nigelzor
Copy link
Contributor Author

The application I was looking at had ~350 GC events per minute. A 2-hour log (6 MB) made GCViewer unresponsive and very difficult to scroll.

After these changes, I've looked at 200,000-event log files with no difficulty.

@vlsi
Copy link

vlsi commented Nov 30, 2012

You rock!
My 28MiB gc log with 200K events renders with no problems.

@chewiebug
Copy link
Owner

Neil - thank you again for contributing! I am happy to see that the patch helps.

Would one of you be willing to send me a large log file to [email protected] or using http://www.fileconvoy.com/index.php? I'd like to have one for later regression testing.

Regards, Jörg

chewiebug added a commit that referenced this pull request Jan 28, 2013
…ntroduced with clipping of polygons in issue #48)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants