iOS 16.4 printing - background graphics support #294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iOS 16.4 add property to allow background graphics when printing the web page. Default value is false, so I need to do this change to allow background graphics.
Only set shouldPrintBackgrounds by options.
arjun-mavonic
approved these changes
Jul 17, 2023
|
Thank you for finding this! It was driving me mad and I'd not discovered the cause myself. 😄 |
liamjones
suggested changes
Jul 24, 2023
|
|
||
| if (@available(iOS 16.4, *)) { | ||
| if (options[@"backgroundGraphics"]) { | ||
| _webView.configuration.preferences.shouldPrintBackgrounds = [options[@"backgroundGraphics"] boolValue]; |
There was a problem hiding this comment.
I believe the option should be converted via RCTConvert.
Suggested change
| _webView.configuration.preferences.shouldPrintBackgrounds = [options[@"backgroundGraphics"] boolValue]; | |
| _webView.configuration.preferences.shouldPrintBackgrounds = [RCTConvert BOOL:options[@"backgroundGraphics"]]; |
There was a problem hiding this comment.
Also, [WKWebView configuration] should only be accessed from the main thread.
Suggested change
| _webView.configuration.preferences.shouldPrintBackgrounds = [options[@"backgroundGraphics"] boolValue]; | |
| dispatch_sync(dispatch_get_main_queue(), ^{ | |
| _webView.configuration.preferences.shouldPrintBackgrounds = [RCTConvert BOOL:options[@"backgroundGraphics"]]; | |
| }); |
Kristinn-Thor
approved these changes
Aug 30, 2023
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
iOS 16.4 add property to allow background graphics when printing the web page. Default value is false, so I need to do this change to allow background graphics.
There is a link to Apple change log.