feat: upgrade deprecated dms versions #18

oycyc · 2025-02-28T00:38:53Z

what

upgrades the default DMS engine version (old version is deprecated) -- this new version will last until at least 2026
upgrades the default DMS instance machine type (old is deprecated)

why

references

https://docs.aws.amazon.com/dms/latest/userguide/CHAP_ReleaseNotes.html

Summary by CodeRabbit

Chores
- Upgraded the replication instance’s engine version to improve performance.
- Updated default resource settings for enhanced reliability and flexibility.

coderabbitai · 2025-02-28T00:39:01Z

Walkthrough

The pull request updates the default configuration values for a replication instance in the file src/variables.tf. The changes upgrade the engine version from "3.4" to "3.5.4" and change the instance class from "dms.t2.small" to "dms.t3.small". These modifications adjust the replication instance settings without altering the core functionality.

Changes

File	Change Summary
src/variables.tf	Updated `engine_version` default from "3.4" to "3.5.4" and `replication_instance_class` default from "dms.t2.small" to "dms.t3.small".

Sequence Diagram(s)

Poem

I’m a hopping rabbit with code in sight,
Upgrading defaults to make things right,
Engine revs now zooming at "3.5.4",
Instance classes leap, offering more,
In config meadows where values bloom bright,
I celebrate changes with boundless delight!
🐰✨

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c548d6e and 039bbc3.

📒 Files selected for processing (1)

src/variables.tf (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (3)

GitHub Check: Mergify Merge Protections
GitHub Check: Mergify Merge Protections
GitHub Check: Summary

🔇 Additional comments (2)

src/variables.tf (2)

36-40: Engine Version Default Update: Verify Compatibility and Documentation.
The default value for the engine_version variable has been updated from "3.4" to "3.5.4". Ensure that this newer version is fully compatible with all deployment environments and that any related documentation is revised to reflect this change.

60-64: Replication Instance Class Update: Validate Performance and Cost Impacts.
The default for replication_instance_class has been modified from "dms.t2.small" to "dms.t3.small". Please confirm that the new instance class meets the performance requirements and cost expectations for your workloads. It could also be beneficial to update any documentation or usage notes to highlight this upgrade.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

mergify · 2025-02-28T00:39:28Z

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 Require terratest

Wonderful, this rule succeeded.

This rule require terratest status

check-success = test/terratest

Gowiem · 2025-03-25T16:54:46Z

/terratest

goruha · 2025-03-28T20:21:48Z

/terratest

mergify · 2025-03-30T00:38:39Z

Heads up! This pull request looks stale. It will be closed soon, if there are no new commits. ⏳

mergify · 2025-04-06T00:39:52Z

Heads up! This pull request looks stale. It will be closed soon, if there are no new commits. ⏳

mergify · 2025-04-13T00:41:36Z

Heads up! This pull request looks stale. It will be closed soon, if there are no new commits. ⏳

mergify · 2025-04-20T00:42:55Z

Heads up! This pull request looks stale. It will be closed soon, if there are no new commits. ⏳

mergify · 2025-04-23T00:45:02Z

Thanks @oycyc for creating this pull request!

A maintainer will review your changes shortly. Please don't be discouraged if it takes a while.

While you wait, make sure to review our contributor guidelines.

Tip

Need help or want to ask for a PR review to be expedited?

Join us on Slack in the #pr-reviews channel.

gberenice · 2025-04-23T08:01:06Z

/terratest

This Pull Request was updated, so we're dismissing all reviews.

github-actions · 2025-04-23T08:03:25Z

There are no real tests for this component. So we set terratest statuses to successful execution without running any tests

github-actions · 2025-04-23T08:21:30Z

These changes were released in v1.535.1.

feat: upgrade deprecated dms versions

039bbc3

oycyc requested review from a team as code owners February 28, 2025 00:38

Gowiem previously approved these changes Feb 28, 2025

View reviewed changes

mergify bot added stale This PR has gone stale and removed stale This PR has gone stale labels Mar 30, 2025

mergify bot added stale This PR has gone stale and removed stale This PR has gone stale labels Apr 6, 2025

mergify bot added stale This PR has gone stale and removed stale This PR has gone stale labels Apr 13, 2025

mergify bot added stale This PR has gone stale and removed stale This PR has gone stale labels Apr 20, 2025

Merge branch 'main' into patch-1

805b011

mergify bot added needs-test Needs testing triage Needs triage labels Apr 23, 2025

gberenice approved these changes Apr 23, 2025

View reviewed changes

gberenice merged commit 42fc5ff into cloudposse-terraform-components:main Apr 23, 2025
41 of 43 checks passed

mergify bot removed the triage Needs triage label Apr 23, 2025

Uh oh!

feat: upgrade deprecated dms versions #18

feat: upgrade deprecated dms versions #18

Uh oh!

Conversation

oycyc commented Feb 28, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

what

why

references

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Feb 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

mergify bot commented Feb 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge Protections

🟢 Require terratest

Uh oh!

Gowiem commented Mar 25, 2025

Uh oh!

goruha commented Mar 28, 2025

Uh oh!

mergify bot commented Mar 30, 2025

Uh oh!

mergify bot commented Apr 6, 2025

Uh oh!

mergify bot commented Apr 13, 2025

Uh oh!

mergify bot commented Apr 20, 2025

Uh oh!

mergify bot commented Apr 23, 2025

Need help or want to ask for a PR review to be expedited?

Uh oh!

gberenice commented Apr 23, 2025

Uh oh!

github-actions bot commented Apr 23, 2025

Uh oh!

Uh oh!

github-actions bot commented Apr 23, 2025

Uh oh!

Uh oh!

oycyc commented Feb 28, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Feb 28, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

mergify bot commented Feb 28, 2025 •

edited

Loading