-
-
Notifications
You must be signed in to change notification settings - Fork 0
Fix datadog provider configuration #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe module source for Changes
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
/terratest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/providers.tf
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Summary
@@ -14,6 +14,6 @@ provider "aws" { | |||
} | |||
|
|||
module "iam_roles" { | |||
source = "../../../account-map/modules/iam-roles" | |||
source = "github.com/cloudposse-terraform-components/aws-account-map//src/modules/iam-roles?ref=tags/v1.535.3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Use explicit Git VCS source syntax for the module.
Terraform requires remote modules sourced from Git to be prefixed with git::
and include the .git
extension to ensure reliable resolution.
Apply this diff:
- source = "github.com/cloudposse-terraform-components/aws-account-map//src/modules/iam-roles?ref=tags/v1.535.3"
+ source = "git::https://github.com/cloudposse-terraform-components/aws-account-map.git//src/modules/iam-roles?ref=v1.535.3"
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
source = "github.com/cloudposse-terraform-components/aws-account-map//src/modules/iam-roles?ref=tags/v1.535.3" | |
source = "git::https://github.com/cloudposse-terraform-components/aws-account-map.git//src/modules/iam-roles?ref=v1.535.3" |
🤖 Prompt for AI Agents
In src/providers.tf at line 17, the module source URL is missing the explicit
Git VCS prefix and the .git extension. Update the source string to start with
"git::" and append ".git" to the repository URL to comply with Terraform's
requirements for remote Git modules.
There are no real tests for this component. So we set terratest statuses to successful execution without running any tests |
These changes were released in v1.535.1. |
what
why
Summary by CodeRabbit