Skip to content

Fix datadog provider configuration #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2025

Conversation

goruha
Copy link
Contributor

@goruha goruha commented Jun 4, 2025

what

  • Replace relative path for datadog creds module with git reference to the component

why

  • After we split monorepo we can not use relative paths for component references

Summary by CodeRabbit

  • Chores
    • Updated the source of the IAM roles module to use a remote GitHub repository instead of a local path.

Copy link

coderabbitai bot commented Jun 4, 2025

Walkthrough

The module source for iam_roles in the Terraform configuration was updated from a local path to a specific tagged version in a remote GitHub repository. No other changes were made to the configuration or provider declarations.

Changes

File(s) Change Summary
src/providers.tf Updated iam_roles module source from a local path to a remote GitHub repository with a specific tag.

Poem

A hop and a skip, the roles now remote,
From local to GitHub, on cloud waves we float.
No more old paths to trip or confuse,
Just tagged perfection—easy to use!
With every deploy, we leap with glee,
For tidy modules set us free.
🐇✨


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@mergify mergify bot requested review from a team June 4, 2025 19:25
@mergify mergify bot added the triage Needs triage label Jun 4, 2025
@goruha
Copy link
Contributor Author

goruha commented Jun 4, 2025

/terratest

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 372993c and 1f9f2f4.

📒 Files selected for processing (1)
  • src/providers.tf (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Summary

@@ -14,6 +14,6 @@ provider "aws" {
}

module "iam_roles" {
source = "../../../account-map/modules/iam-roles"
source = "github.com/cloudposse-terraform-components/aws-account-map//src/modules/iam-roles?ref=tags/v1.535.3"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Use explicit Git VCS source syntax for the module.
Terraform requires remote modules sourced from Git to be prefixed with git:: and include the .git extension to ensure reliable resolution.
Apply this diff:

-  source  = "github.com/cloudposse-terraform-components/aws-account-map//src/modules/iam-roles?ref=tags/v1.535.3"
+  source  = "git::https://github.com/cloudposse-terraform-components/aws-account-map.git//src/modules/iam-roles?ref=v1.535.3"
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
source = "github.com/cloudposse-terraform-components/aws-account-map//src/modules/iam-roles?ref=tags/v1.535.3"
source = "git::https://github.com/cloudposse-terraform-components/aws-account-map.git//src/modules/iam-roles?ref=v1.535.3"
🤖 Prompt for AI Agents
In src/providers.tf at line 17, the module source URL is missing the explicit
Git VCS prefix and the .git extension. Update the source string to start with
"git::" and append ".git" to the repository URL to comply with Terraform's
requirements for remote Git modules.

Copy link

github-actions bot commented Jun 4, 2025

There are no real tests for this component. So we set terratest statuses to successful execution without running any tests

@goruha goruha merged commit 3c2fe72 into main Jun 4, 2025
19 checks passed
@goruha goruha deleted the fix-datadog-provider-configuration branch June 4, 2025 19:28
@mergify mergify bot removed the triage Needs triage label Jun 4, 2025
Copy link

github-actions bot commented Jun 4, 2025

These changes were released in v1.535.1.

@coderabbitai coderabbitai bot mentioned this pull request Jun 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant