Skip to content

feat: add missed vars for SG module and update deps #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 15, 2021
Merged

Conversation

SweetOps
Copy link
Contributor

@SweetOps SweetOps commented May 18, 2021

what

  • add missed vars for SG
  • bump to SG module to 0.3.1
  • update tests

why

  • bring configuration of security group/rules to one standard

references

  • CPCO-409

@SweetOps SweetOps requested review from a team as code owners May 18, 2021 17:57
@SweetOps SweetOps requested review from joe-niland and nitrocode May 18, 2021 17:57
@SweetOps SweetOps marked this pull request as draft May 20, 2021 15:43
@SweetOps
Copy link
Contributor Author

/test all

@SweetOps SweetOps marked this pull request as ready for review May 20, 2021 16:37
@SweetOps
Copy link
Contributor Author

/test all

@mergify
Copy link

mergify bot commented May 20, 2021

This pull request is now in conflict. Could you fix it @SweetOps? 🙏

@SweetOps
Copy link
Contributor Author

/test all

@mergify
Copy link

mergify bot commented Jun 3, 2021

This pull request is now in conflict. Could you fix it @SweetOps? 🙏

@SweetOps
Copy link
Contributor Author

SweetOps commented Jun 8, 2021

/test all

@nitrocode nitrocode merged commit f251bf5 into master Jun 15, 2021
@nitrocode nitrocode deleted the CPCO-409 branch June 15, 2021 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants