Skip to content

Feat: Add instance_initiated_shutdown_behavior Variable #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 3, 2021

Conversation

korenyoni
Copy link
Member

what

  • Add instance_initiated_shutdown_behavior variable

why

  • This variable allows for more fine-grained aws_instance resource customization

references

  • N/A

@korenyoni korenyoni requested review from a team as code owners June 3, 2021 11:44
@korenyoni
Copy link
Member Author

/test all

Copy link

@bridgecrew bridgecrew bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bridgecrew has found 1 infrastructure configuration error in this PR ⬇️

source_dest_check = var.source_dest_check
ipv6_address_count = var.ipv6_address_count < 0 ? null : var.ipv6_address_count
ipv6_addresses = length(var.ipv6_addresses) == 0 ? null : var.ipv6_addresses
count = local.instance_count
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error Description: Ensure that EC2 instances belong to a VPC
Category: Networking | Severity: MEDIUM
Resource: aws_instance [default], lines: 108 - 153

@korenyoni korenyoni requested a review from a team as a code owner June 3, 2021 11:44
@korenyoni korenyoni requested review from jamengual and joe-niland June 3, 2021 11:44
@korenyoni
Copy link
Member Author

/test all

nitrocode
nitrocode previously approved these changes Jun 3, 2021
@korenyoni korenyoni force-pushed the feat/add-instance-initiated-shutdown-behavior-var branch from 94d898a to 95070ce Compare June 3, 2021 12:25
@korenyoni
Copy link
Member Author

/test all

cloudpossebot and others added 3 commits June 3, 2021 12:26
…ncorrectly flagging that this instance does not belong to a VPC even though subnet_id is configured.
…ithub.com:cloudposse/terraform-aws-ec2-instance into feat/add-instance-initiated-shutdown-behavior-var
@korenyoni
Copy link
Member Author

/test all

@korenyoni korenyoni merged commit a8bc162 into master Jun 3, 2021
@korenyoni korenyoni deleted the feat/add-instance-initiated-shutdown-behavior-var branch June 3, 2021 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants