Skip to content

Adding SSM patch support #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 24 commits into from
Jun 24, 2021
Merged

Adding SSM patch support #103

merged 24 commits into from
Jun 24, 2021

Conversation

jamengual
Copy link
Contributor

what

  • Add SSM log bucket access
  • Add SSM policy for Patch Manager
  • Allow for Custom SSM policy

why

  • To be able to integrate with SSM patch and log the patch logs to an S3 bucket.

@jamengual jamengual requested review from a team as code owners June 22, 2021 19:45
@jamengual jamengual requested review from Gowiem and brcnblc June 22, 2021 19:45
@jamengual
Copy link
Contributor Author

/test all

aknysh
aknysh reviewed Jun 22, 2021
View reviewed changes
aknysh
aknysh reviewed Jun 22, 2021
View reviewed changes
aknysh
aknysh reviewed Jun 22, 2021
View reviewed changes
aknysh
aknysh reviewed Jun 22, 2021
View reviewed changes
aknysh
aknysh reviewed Jun 22, 2021
View reviewed changes
aknysh
aknysh reviewed Jun 22, 2021
View reviewed changes
aknysh
aknysh reviewed Jun 22, 2021
View reviewed changes
aknysh
aknysh reviewed Jun 22, 2021
View reviewed changes
aknysh
aknysh previously requested changes Jun 22, 2021
View reviewed changes
Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please see comments

jamengual and others added 4 commits June 22, 2021 13:30
@jamengual @aknysh
Update main.tf
9219b10 
Co-authored-by: Andriy Knysh <[email protected]>
@jamengual @aknysh
Update main.tf
193d691 
Co-authored-by: Andriy Knysh <[email protected]>
@jamengual @aknysh
Update variables.tf
07de895 
Co-authored-by: Andriy Knysh <[email protected]>
@cloudpossebot
Auto Format
9f1088c
@mergify mergify bot dismissed aknysh’s stale review June 22, 2021 20:31

This Pull Request has been updated, so we're dismissing all reviews.

jamengual and others added 4 commits June 22, 2021 13:32
@jamengual @aknysh
Update main.tf
9f00bf2 
Co-authored-by: Andriy Knysh <[email protected]>
@jamengual @aknysh
Update main.tf
1a98cd1 
Co-authored-by: Andriy Knysh <[email protected]>
@jamengual
Adding SSM patch support
1edc0a8
@jamengual @aknysh
Update main.tf
b798e3a 
Co-authored-by: Andriy Knysh <[email protected]>
@jamengual
Copy link
Contributor Author

/test all

@jamengual
Copy link
Contributor Author

/test all

@aknysh
Copy link
Member

aknysh commented Jun 22, 2021

@jamengual please check the failed tests and ifx

count      = local.enabled ? local.instance_profile_count : 0

A local value with the name "enabled" has not been declared.

aknysh
aknysh reviewed Jun 22, 2021
View reviewed changes
aknysh
aknysh reviewed Jun 22, 2021
View reviewed changes
aknysh
aknysh previously requested changes Jun 22, 2021
View reviewed changes
Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please see comments

@jamengual
Copy link
Contributor Author

/test all

@mergify mergify bot dismissed aknysh’s stale review June 22, 2021 23:15

This Pull Request has been updated, so we're dismissing all reviews.

aknysh
aknysh reviewed Jun 23, 2021
View reviewed changes
aknysh
aknysh reviewed Jun 23, 2021
View reviewed changes
aknysh
aknysh reviewed Jun 23, 2021
View reviewed changes
aknysh
aknysh reviewed Jun 23, 2021
View reviewed changes
Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a few nitpicks

jamengual and others added 3 commits June 23, 2021 10:06
@jamengual @aknysh
Update main.tf
c50f64b 
Co-authored-by: Andriy Knysh <[email protected]>
@jamengual @aknysh
Update main.tf
0ed01c4 
Co-authored-by: Andriy Knysh <[email protected]>
@jamengual
Minor fixes
ebe00ab
@jamengual
Copy link
Contributor Author

/test all

@jamengual jamengual merged commit 8c2ca76 into master Jun 24, 2021
@jamengual jamengual deleted the add_ssm_patch_support branch June 24, 2021 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aknysh aknysh aknysh approved these changes

@Gowiem Gowiem Awaiting requested review from Gowiem

@brcnblc brcnblc Awaiting requested review from brcnblc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jamengual @aknysh @cloudpossebot