Utilize TF locals feature in order to implement instance switch option
#11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
const-bon
reviewed
Oct 9, 2017
main.tf
Outdated
| @@ -28,14 +28,18 @@ module "label" { | |||
| tags = "${var.tags}" | |||
| } | |||
|
|
|||
| locals { | |||
| instance_count = "${var.instance_enabled == true ? 1 : 0}" | |||
There was a problem hiding this comment.
It can be simplified to var.instance_enabled ? 1 : 0
const-bon
suggested changes
Oct 9, 2017
main.tf
Outdated
| @@ -113,7 +117,7 @@ resource "aws_instance" "default" { | |||
| } | |||
|
|
|||
| resource "aws_eip" "default" { | |||
| count = "${var.associate_public_ip_address && var.instance_enabled ? 1 : 0}" | |||
| count = "${var.associate_public_ip_address && local.instance_count ? 1 : 0}" | |||
There was a problem hiding this comment.
var.associate_public_ip_address && local.instance_count means bool && int.
Should be replaced with corresponding locals too.
There was a problem hiding this comment.
We shouldn't mix bool and int into a single expression. Use bool instead of int.
There was a problem hiding this comment.
Nevermind, Booleans says, that int 1 will be interpolated as true and int 0 as false.
|
|
s2504s
force-pushed
the
change_var_to_locals
branch
from
ddaa2dc to
ab7e8cb
Compare
const-bon
reviewed
Oct 10, 2017
const-bon
reviewed
Oct 11, 2017
main.tf
Outdated
| @@ -28,22 +28,27 @@ module "label" { | |||
| tags = "${var.tags}" | |||
| } | |||
|
|
|||
| locals { | |||
| instance_count = "${var.instance_enabled ? 1 : 0}" | |||
| create_security_group = "${var.create_default_security_group ? 1 : 0}" | |||
There was a problem hiding this comment.
security_group_count would be more precise.
s2504s
force-pushed
the
change_var_to_locals
branch
from
124c385 to
1b25790
Compare
const-bon
reviewed
Oct 11, 2017
main.tf
Outdated
| @@ -28,22 +28,27 @@ module "label" { | |||
| tags = "${var.tags}" | |||
| } | |||
|
|
|||
| locals { | |||
| instance_count = "${var.instance_enabled ? 1 : 0}" | |||
| security_grou_count = "${var.create_default_security_group ? 1 : 0}" | |||
s2504s
force-pushed
the
change_var_to_locals
branch
from
1b25790 to
7c88d1f
Compare
|
|
const-bon
approved these changes
Oct 12, 2017
const-bon
changed the title
locals for instance_countlocals feature in order to implement instance switch option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
localsfeature in order to implement instance switch optionWhy
booleanvalue withcountattribute. TF interpolates"true"/"false"strings as booleans, but can't interpolatestring->boolean->intterraform-aws-ec2-instancein order to create replicas, we might be interested inswitchfor those replicas, or replica groupsPlan