Skip to content

Correct how the volume_id is selected - Fix #165 #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 18, 2023
Merged

Correct how the volume_id is selected - Fix #165 #171

merged 1 commit into from
Aug 18, 2023

Conversation

it-praktyk
Copy link
Contributor

what

Fix #165 - allows create an EC2 instance with additional volumes.

why

The issue was introduced here.

The one Terraform function returns an error, that blocks creating EC2 instances with additional (non-root) volumes.

references

closes #165

@it-praktyk it-praktyk requested review from a team as code owners August 15, 2023 15:42
@it-praktyk it-praktyk requested review from Gowiem and korenyoni August 15, 2023 15:42
@it-praktyk
Copy link
Contributor Author

Hi,
I've checked the failed check. Fail is related to a CI process itself.

- Installing hashicorp/aws v5.12.0...
╷
│ Error: Failed to install provider
│ 
│ Error while installing hashicorp/aws v5.12.0: releases.hashicorp.com: Get
│ "https://releases.hashicorp.com/terraform-provider-aws/5.12.0/terraform-provider-aws_5.12.0_linux_amd64.zip":
│ read tcp 10.1.0.21:33138->13.33.21.37:443: read: connection reset by peer
╵

Error: Terraform exited with code 1.
Error: Process completed with exit code 1.

Can we proceed with a review even when the check failed?

@joe-niland joe-niland added the minor New features that do not break anything label Aug 17, 2023
@joe-niland
Copy link
Member

/terratest

@joe-niland joe-niland self-requested a review August 18, 2023 03:57
@joe-niland joe-niland merged commit a4a943c into cloudposse:main Aug 18, 2023
@joe-niland
Copy link
Member

Thanks for your contribution @it-praktyk

@it-praktyk it-praktyk deleted the Correct_the_issue_165 branch August 20, 2023 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor New features that do not break anything
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid index in aws_volume_attachment volume_id parameter
2 participants