Skip to content

Add user_data_replace_on_change #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 25, 2024
Merged

Add user_data_replace_on_change #188

merged 7 commits into from
Mar 25, 2024

Conversation

bwmetcalf
Copy link
Contributor

@bwmetcalf bwmetcalf commented Mar 19, 2024

what

Support user_data_replace_on_change:

[user_data_replace_on_change](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/instance#user_data_replace_on_change) - (Optional) When used in combination with user_data or user_data_base64 will trigger a destroy and recreate when set to true. Defaults to false if not set.

Bumps minimum aws provider version to support this parameter.

why

Force a rebuild if user data has changed.

@bwmetcalf bwmetcalf requested review from a team as code owners March 19, 2024 19:52
@mergify mergify bot added the triage Needs triage label Mar 19, 2024
@woz5999
Copy link
Contributor

woz5999 commented Mar 19, 2024

This is extremely useful for immutable infrastructure

@bwmetcalf
Copy link
Contributor Author

bwmetcalf commented Mar 20, 2024

@nitrocode @aknysh Could you review?

@joe-niland
Copy link
Member

Thanks @bwmetcalf would you mind generating the readme again? If it outputs >= 0.13 again for min tf version, please delete any lock files you have and try again.

@joe-niland joe-niland self-requested a review March 20, 2024 01:29
@joe-niland joe-niland removed the triage Needs triage label Mar 20, 2024
@mergify mergify bot added the triage Needs triage label Mar 20, 2024
@joe-niland joe-niland added the minor New features that do not break anything label Mar 20, 2024
@bwmetcalf
Copy link
Contributor Author

Thanks @bwmetcalf would you mind generating the readme again? If it outputs >= 0.13 again for min tf version, please delete any lock files you have and try again.

I think this is good now. Thanks!

nitrocode
nitrocode previously approved these changes Mar 20, 2024
@mergify mergify bot removed the triage Needs triage label Mar 20, 2024
@nitrocode
Copy link
Member

@bwmetcalf
Copy link
Contributor Author

Anything else needed here to get this merged and a new release generated?

@bwmetcalf
Copy link
Contributor Author

@nitrocode @joe-niland @aknysh Anything else needed to get this merged and a new release generated? Thank you.

@joe-niland
Copy link
Member

/terratest

@joe-niland joe-niland enabled auto-merge (squash) March 24, 2024 21:35
@joe-niland joe-niland disabled auto-merge March 24, 2024 21:51
@aknysh aknysh merged commit a8a3214 into cloudposse:main Mar 25, 2024
@joe-niland
Copy link
Member

Thanks for your contribution @bwmetcalf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor New features that do not break anything
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants