-
-
Notifications
You must be signed in to change notification settings - Fork 223
Added user data #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Do we really need user data? If the user data is changed, instance will be recreated. |
@comeanother
Yes we need.
I do not want to add additional tool for small functionality.
True. But even in current situation if you will change github auth keys params instance would be rebuilded. |
main.tf
Outdated
@@ -103,7 +113,7 @@ resource "aws_eip" "default" { | |||
|
|||
# Apply the provisioner module for this resource | |||
module "ansible" { | |||
source = "git::https://github.com/cloudposse/tf_ansible.git?ref=tags/0.2.0" | |||
source = "git::https://github.com/cloudposse/tf_ansible.git" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you remove ?ref=tags/0.2.0
? If this tag do not corresponds to the latest commit in master let me know, I can add new tag.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch. Sec
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
What
Why