Added private_dns and private_ip to output
#4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osterman
reviewed
Sep 4, 2017
| value = "${aws_instance.default.private_ip}" | ||
| } | ||
|
|
||
| output "private_dns" { |
There was a problem hiding this comment.
I'm torn. In the past, I've said use the original resource name (in this case private_dns). However, we're using public_hostname below. I think we should use one convention or another, but not both.
There was a problem hiding this comment.
I defer to @comeanother to pick the right convention.
There was a problem hiding this comment.
I think we should use the original resource name. I'll rename the variable public_hostname to public_dns
osterman
approved these changes
Sep 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
##What
private_dnsandprivate_ipto outputWhy