Skip to content

Add var.volume_tags_enabled #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 27, 2021
Merged

Add var.volume_tags_enabled #92

merged 6 commits into from
Apr 27, 2021

Conversation

gregnphe
Copy link
Contributor

@gregnphe gregnphe commented Mar 25, 2021 •
edited
Loading

what

  • Volumes are tagged the same as the EC2 instance they're created for

why

  • It's helpful to tag volumes like the instance they're used on
  • Untagged volumes can accumulate and become difficult to manage

references

@gregnphe gregnphe marked this pull request as ready for review March 29, 2021 08:53
@gregnphe gregnphe requested review from a team as code owners March 29, 2021 08:53
@gregnphe gregnphe requested review from jamengual and nitrocode March 29, 2021 08:53
@mergify
Copy link

mergify bot commented Apr 26, 2021

This pull request is now in conflict. Could you fix it @gregnphe? 🙏

@Gowiem
Copy link
Member

Gowiem commented Apr 26, 2021

/rebuild-readme

Gowiem
Gowiem reviewed Apr 26, 2021
View reviewed changes
@Gowiem
Copy link
Member

Gowiem commented Apr 26, 2021

@gregnphe please also address the merge conflicts -- Thanks!

@Gowiem
Copy link
Member

Gowiem commented Apr 27, 2021

/test all

@Gowiem Gowiem merged commit 5912bb3 into cloudposse:master Apr 27, 2021
@Gowiem
Copy link
Member

Gowiem commented Apr 27, 2021

Thanks for the contribution @gregnphe! Released as 0.32.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gowiem Gowiem Gowiem approved these changes

@jamengual jamengual Awaiting requested review from jamengual

@nitrocode nitrocode Awaiting requested review from nitrocode

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for volume_tags
4 participants
@gregnphe @Gowiem @cloudpossebot @actions-bot