Skip to content

change network_interface to instance in aws_eip resource #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 7, 2021
Merged

change network_interface to instance in aws_eip resource #96

merged 5 commits into from
Jun 7, 2021

Conversation

ByJacob
Copy link
Contributor

@ByJacob ByJacob commented May 6, 2021

what

  • Change network_interfface to instance in aws_eip

why

  • Unable to modify the network interface while the instance is in 'terminate' state

references

@ByJacob ByJacob requested review from a team as code owners May 6, 2021 08:38
@ByJacob ByJacob changed the title change network_interface to instance change network_interface to instance in aws_eip resource May 6, 2021
@joe-niland
Copy link
Member

/test all

@ByJacob
Copy link
Contributor Author

ByJacob commented May 6, 2021

Error in terratest is related with cloudposse/terraform-aws-security-group#13

Jakub Rosa and others added 2 commits May 26, 2021 17:08
@ByJacob ByJacob requested a review from a team as a code owner May 26, 2021 15:09
@ByJacob ByJacob requested review from Gowiem and adamcrews May 26, 2021 15:09
@ByJacob
Copy link
Contributor Author

ByJacob commented May 31, 2021

PING :)

@aknysh
Copy link
Member

aknysh commented Jun 6, 2021

/test all

@aknysh
Copy link
Member

aknysh commented Jun 6, 2021

@ByJacob thanks, LGTM
Can you please run

make init
make github/init
make readme

to update the GitHub actions to the latest versions?

@ByJacob ByJacob requested a review from a team as a code owner June 7, 2021 06:57
@aknysh
Copy link
Member

aknysh commented Jun 7, 2021

/test all

aknysh
aknysh approved these changes Jun 7, 2021
View reviewed changes
Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @ByJacob

@aknysh aknysh merged commit d5821e8 into cloudposse:master Jun 7, 2021
@ByJacob
Copy link
Contributor Author

ByJacob commented Jun 7, 2021

No problem. I often have some non-standard use cases and try to correct it in my spare time :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aknysh aknysh aknysh approved these changes

@Gowiem Gowiem Awaiting requested review from Gowiem

@adamcrews adamcrews Awaiting requested review from adamcrews

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ByJacob @joe-niland @aknysh @cloudpossebot