Skip to content

fix(attribute_parser): dont panic at Attribute Exeptions anymore #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 19, 2023
Merged

fix(attribute_parser): dont panic at Attribute Exeptions anymore #80

merged 1 commit into from
Dec 19, 2023

Conversation

Kerreytsugo
Copy link
Contributor

No description provided.

@Kerreytsugo Kerreytsugo self-assigned this Dec 19, 2023
liketechnik
liketechnik approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@liketechnik liketechnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One could argue that we should at least warn that we are totally ignoring this attribute, but well...

@liketechnik liketechnik merged commit 4d80105 into main Dec 19, 2023
@Kerreytsugo Kerreytsugo mentioned this pull request Dec 19, 2023
Closed
@JonaZz747 JonaZz747 deleted the fix_parse_exeption_attribue branch January 6, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liketechnik liketechnik liketechnik approved these changes

@Aetlam Aetlam Aetlam approved these changes

Assignees

@Kerreytsugo Kerreytsugo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kerreytsugo @liketechnik @Aetlam