Skip to content

feat(244): Allow Slideshow controls to autoFocus #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 29, 2022

Conversation

brianespinosa
Copy link
Contributor

@brianespinosa brianespinosa commented Jul 28, 2022

Resolves #244

Feel free to decline if you do not think we should add this. Or if you would like to suggest a different approach, I am happy to make some modifications.

Version

Published prerelease version: v0.7.3-next.0

Changelog

🐛 Bug Fix

⚠️ Pushed to next

  • Update bundle_analysis.yml (@pomber)

Authors: 2

@vercel
Copy link

vercel bot commented Jul 28, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
chtest ✅ Ready (Inspect) Visit Preview Jul 29, 2022 at 8:39AM (UTC)
playground ✅ Ready (Inspect) Visit Preview Jul 29, 2022 at 8:39AM (UTC)

@vercel vercel bot temporarily deployed to Preview – playground July 28, 2022 02:51 Inactive
@vercel vercel bot temporarily deployed to Preview – chtest July 28, 2022 02:53 Inactive
@vercel vercel bot temporarily deployed to Preview – playground July 28, 2022 03:14 Inactive
@vercel vercel bot temporarily deployed to Preview – chtest July 28, 2022 03:15 Inactive
@pomber pomber added patch release PR created automatically for new releases labels Jul 28, 2022
@pomber
Copy link
Contributor

pomber commented Jul 28, 2022

I was trying to make the bots release a canary version but it didn't work 🤷 . I'll take a look later.

@vercel vercel bot temporarily deployed to Preview – playground July 29, 2022 08:38 Inactive
@vercel vercel bot temporarily deployed to Preview – chtest July 29, 2022 08:39 Inactive
@pomber
Copy link
Contributor

pomber commented Jul 29, 2022

I renamed the prop to autoFocus because it's practically the same as the HTML autofocus attribute.

I'll merge this, but first I want to see if I can fix the bots permissions.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2022

🚀 PR was released in v0.7.3 🚀

@brianespinosa brianespinosa deleted the main branch August 16, 2022 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release PR created automatically for new releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: Allow autoFocus to be configured for CH.Slideshow input range controls
2 participants