Skip to content

rows prop when you have two panels #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 16, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions packages/mdx/dev/content/rows.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -65,3 +65,22 @@ console.log(7)
```

</CH.Code>

<CH.Code rows={[2, "focus"]} lineNumbers >

```js foo.js
console.log(2)
```

---

```js bar.js focus=3:4
console.log(1)
console.log(2)
console.log(3)
console.log(4)
console.log(5)
console.log(7)
```

</CH.Code>
32 changes: 26 additions & 6 deletions packages/mdx/src/mini-editor/editor-shift.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,26 @@ type Snapshot = {
southTabs: TabsSnapshot | null
}

function northConfig(codeConfig: CodeConfig) {
if (Array.isArray(codeConfig.rows)) {
return {
...codeConfig,
rows: codeConfig.rows[0],
}
}
return codeConfig
}

function southConfig(codeConfig: CodeConfig) {
if (Array.isArray(codeConfig.rows)) {
return {
...codeConfig,
rows: codeConfig.rows[1],
}
}
return codeConfig
}

export function useTransition(
ref: React.RefObject<HTMLDivElement>,
prev: EditorStep,
Expand Down Expand Up @@ -119,7 +139,7 @@ export function useTransition(
style: northStyle,
children: (
<CodeTransition
codeConfig={codeConfig}
codeConfig={northConfig(codeConfig)}
prevFile={prevNorthFile}
nextFile={nextNorthFile}
t={t}
Expand All @@ -136,7 +156,7 @@ export function useTransition(
style: southStyle!,
children: (
<CodeTransition
codeConfig={codeConfig}
codeConfig={southConfig(codeConfig)}
prevFile={prevSouthFile!}
nextFile={nextSouthFile!}
t={t}
Expand Down Expand Up @@ -180,7 +200,7 @@ function startingPosition(
},
children: (
<CodeTransition
codeConfig={codeConfig}
codeConfig={northConfig(codeConfig)}
prevFile={prevNorthFile}
nextFile={prevNorthFile}
t={0}
Expand All @@ -201,7 +221,7 @@ function startingPosition(
},
children: (
<CodeTransition
codeConfig={codeConfig}
codeConfig={southConfig(codeConfig)}
prevFile={prevSouthFile!}
nextFile={prevSouthFile!}
t={0}
Expand Down Expand Up @@ -249,7 +269,7 @@ function endingPosition(
},
children: (
<CodeTransition
codeConfig={codeConfig}
codeConfig={northConfig(codeConfig)}
prevFile={nextNorthFile}
nextFile={nextNorthFile}
t={1}
Expand All @@ -270,7 +290,7 @@ function endingPosition(
},
children: (
<CodeTransition
codeConfig={codeConfig}
codeConfig={southConfig(codeConfig)}
prevFile={nextSouthFile!}
nextFile={nextSouthFile!}
t={1}
Expand Down
4 changes: 2 additions & 2 deletions packages/mdx/src/smooth-code/code-tween.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ export type CodeConfig = {
showCopyButton?: boolean
showExpandButton?: boolean
staticMediaQuery?: string
rows?: number | "focus"
rows?: number | "focus" | (number | "focus")[]
debug?: boolean
}

Expand Down Expand Up @@ -86,7 +86,7 @@ export function CodeTween({
map(tween, tween => tween.focus),
config.minColumns || DEFAULT_MIN_COLUMNS,
config.lineNumbers || false,
config.rows,
config.rows as number | "focus",
[config.parentHeight]
)

Expand Down
Binary file removed packages/storybook/public/codehike.png
Binary file not shown.
Binary file removed packages/storybook/public/favicon-16x16.png
Binary file not shown.
Binary file removed packages/storybook/public/favicon-32x32.png
Binary file not shown.
Binary file removed packages/storybook/public/favicon-96x96.png
Binary file not shown.
Binary file removed packages/storybook/public/favicon.ico
Binary file not shown.
Binary file removed packages/storybook/public/logo.png
Binary file not shown.
20 changes: 0 additions & 20 deletions packages/storybook/src/assets/code-with-links.mdx

This file was deleted.

61 changes: 0 additions & 61 deletions packages/storybook/src/assets/code.mdx

This file was deleted.

Binary file removed packages/storybook/src/assets/count.mp4
Binary file not shown.
79 changes: 0 additions & 79 deletions packages/storybook/src/assets/scrollycoding.basic.mdx

This file was deleted.

79 changes: 0 additions & 79 deletions packages/storybook/src/assets/scrollycoding.deps.mdx

This file was deleted.

Loading