Skip to content

fix: Set correct gatsby peer dep #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2021
Merged

fix: Set correct gatsby peer dep #20

merged 1 commit into from
Apr 15, 2021

Conversation

LekoArts
Copy link
Contributor

Hello @codeAdrian, Gatsby maintainer here 👋
First and foremost, thanks for creating the plugin & maintaining it. Much appreciated!

While looking at your plugin I noticed that the peerDependency on gatsby is set incorrectly. We're in the process of providing more helpful information on the /plugins page of our website and for that we need plugins to set their peerDependencies correctly/more specific.

At the moment you say that any version (v3, v4, v5, v6, etc.) will work with this even when in between we'd introduce breaking changes.

Making it more explicit is the safer choice (in the future you'll be able to mark breaking changes with explicit version ranges) and will allow us to display the plugin as compatible to versions X, Y, Z.

Thanks!

@codeAdrian
Copy link
Owner

Hi @LekoArts , thank you very much for the PR and the very detailed explanation. I appreciate your support!

I am happy to merge this change and create a release right away!

Thanks once again!

@codeAdrian codeAdrian merged commit 8df1887 into codeAdrian:main Apr 15, 2021
@LekoArts LekoArts deleted the patch-1 branch April 15, 2021 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants