Skip to content

feat: support requestOptions prop #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 6, 2023
Merged

Conversation

VanishMax
Copy link
Collaborator

πŸ“‘ Description

Implements #4 – requestOptions prop to support request customization.

βœ… Checks

Make sure your pr passes the CI checks and do check the following fields as needed

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

@VanishMax
Copy link
Collaborator Author

VanishMax commented Dec 6, 2023

@codeacme17 Do I need to build the library and push its output to the repo for this PR?
It seems that pnpm build:types exports types differently on my machine than it did before for you.

@codeacme17
Copy link
Owner

oh sorry, I may need to do some manual work when I package this project, I'll agree to this pr first and then I'll package it. Thank you for your help!

@codeacme17 codeacme17 merged commit db4cee9 into codeacme17:main Dec 6, 2023
@codeacme17
Copy link
Owner

@VanishMax I sent a request to invite you to become a collaborator on this repo. You can agree to the request if you wish, thanks again for your contribution! and I will close the related issue.

@VanishMax
Copy link
Collaborator Author

@codeacme17 Thank you, appreciated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants