Skip to content

Fix Travis Setup for rustc and kcov #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from Mar 14, 2018
Merged

Fix Travis Setup for rustc and kcov #10

merged 3 commits into from Mar 14, 2018

Conversation

ghost
Copy link

@ghost ghost commented Mar 13, 2018

Using the travis.yml setup from the README.md results in the following failures on Travis:
rust stable Linux
rust beta Linux
rust nightly Linux

The builds run again by enabling sudo and removing the link-dead-code flag:
rust stable Linux
rust beta Linux
rust nightly Linux

This issue mentions rustc panicking when using the link-dead-code flag
This issue mentions kcov failing when not using sudo

@sunjay sunjay self-requested a review March 13, 2018 19:45
@sunjay sunjay self-assigned this Mar 13, 2018
@sunjay
Copy link
Collaborator

sunjay commented Mar 14, 2018

Thanks for creating this PR! Could you modify the repository's .travis.yml file in addition to the README.md? We try to keep those in sync. 😄

@ghost
Copy link
Author

ghost commented Mar 14, 2018

Sure thing!
I completely forgot about the actual .travis.yml file.
I'll fix it as soon as I get home.

@codecov
Copy link

codecov bot commented Mar 14, 2018

Codecov Report

Merging #10 into master will increase coverage by 7.4%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #10     +/-   ##
=========================================
+ Coverage   76.47%   83.87%   +7.4%     
=========================================
  Files           1        1             
  Lines          34       31      -3     
=========================================
  Hits           26       26             
+ Misses          8        5      -3
Impacted Files Coverage Δ
src/lib.rs 83.87% <0%> (+7.4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68fab58...f477f18. Read the comment docs.

@ghost
Copy link
Author

ghost commented Mar 14, 2018

The README.md and .travis.yml files should now be in sync.

@sunjay sunjay merged commit 83dfbf9 into codecov:master Mar 14, 2018
@sunjay
Copy link
Collaborator

sunjay commented Mar 14, 2018

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant