Fix Bash glob when Rust hash ends in d #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the Rust hash ends in a "d" the previous blob would fail to match. This is due to codecov#3 which fixed an issue where Rust generated ".d" files that should correctly be filtered. This new version loops over both the correct files and ".d" files. Within the loop it checks for if the file is executable as its filtering of the ".d" files. I believe in general this is a better design as the more advanced Bash glob is not very portable.
sunjay
approved these changes
Feb 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the Rust hash ends in a "d" the previous blob would fail to match.
This is due to #3 which fixed an issue where Rust generated ".d" files
that should correctly be filtered.
This new version loops over both the correct files and ".d" files.
Within the loop it checks for if the file is executable as its
filtering of the ".d" files.
I believe in general this is a better design as the more advanced Bash
glob is not very portable.