Skip to content

Rust version update #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 28, 2017
Merged

Rust version update #4

merged 3 commits into from
Apr 28, 2017

Conversation

serayuzgur
Copy link
Contributor

It will be better to use rust versions like

rust:
  - stable
  - beta
  - nightly

@codecov
Copy link

codecov bot commented Apr 28, 2017

Codecov Report

Merging #4 into master will increase coverage by 1.72%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #4      +/-   ##
==========================================
+ Coverage   82.14%   83.87%   +1.72%     
==========================================
  Files           1        1              
  Lines          28       31       +3     
==========================================
+ Hits           23       26       +3     
  Misses          5        5
Impacted Files Coverage Δ
src/lib.rs 83.87% <0%> (+1.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c53293...e384229. Read the comment docs.

@sunjay
Copy link
Collaborator

sunjay commented Apr 28, 2017

Hi! Thanks for the PR! Could you update the versions to look like the recommended configuration in the documentation? https://docs.travis-ci.com/user/languages/rust/#Choosing-the-Rust-version

It's at the bottom of the section I linked to.

I agree with you that it would be better to list all the versions properly.

Copy link
Collaborator

@sunjay sunjay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Once the build passes this is good to merge.

@sunjay sunjay merged commit c49d31f into codecov:master Apr 28, 2017
@sunjay
Copy link
Collaborator

sunjay commented Apr 28, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants