fix copy error #48
Closed
fix copy error #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sometimes, certain file does not delete and $file->getRealPath() return false. So we need to put some check before copy to avoid argument pass into copy() is empty error.
Codecov Report
@@ Coverage Diff @@
## master #48 +/- ##
============================================
- Coverage 32.48% 30.84% -1.64%
- Complexity 104 111 +7
============================================
Files 13 13
Lines 274 295 +21
============================================
+ Hits 89 91 +2
- Misses 185 204 +19
Continue to review full report at Codecov.
|
|
Will be fixed in #58 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sometimes, certain file does not delete and $file->getRealPath() return false. So we need to put some check before copy to avoid argument pass into copy() is empty error.