Skip to content

Commit 624295c

Browse files
bagel897tkucar
authored and
tkucar
committed
ci: don't report coverage data as json (#307)
# Contents - Remove refrences to old smart-tests flag - Don't report coverage to JSON or XML by default, let the codecov CLI handle that - Random SDK change to test CI # Results - Brings down full run from 11m to 6m
1 parent 5ef9f27 commit 624295c

File tree

5 files changed

+10
-9
lines changed

5 files changed

+10
-9
lines changed

.github/actions/run_ats/action.yml

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,7 @@ inputs:
2121
default: ''
2222
codecov_flags:
2323
description: 'Flags for codecov upload'
24-
required: false
25-
default: 'smart-tests'
24+
required: true
2625

2726
runs:
2827
using: "composite"
@@ -44,7 +43,6 @@ runs:
4443
- name: Run tests
4544
shell: bash
4645
run: |
47-
echo "pwd: $(pwd)" # FIXME: for debugging
4846
TESTS_TO_RUN=$(cat codecov_ats/tests_to_run.txt)
4947
if [ -z "$TESTS_TO_RUN" ]; then
5048
echo "No tests to run, skipping..."
@@ -56,7 +54,6 @@ runs:
5654
-vv \
5755
--cov \
5856
--cov-append \
59-
--cov-report=xml \
6057
${{ inputs.collect_args }}
6158
6259
- uses: ./.github/actions/report

.github/codecov.yml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ component_management:
1717
- type: patch
1818
target: 50 # Language specific featues must be 100% covered
1919
flags:
20-
- smart-tests
20+
- unit-tests
2121
- component_id: codegen-sdk-typescript
2222
name: codegen-sdk-typescript
2323
paths:
@@ -27,10 +27,14 @@ component_management:
2727
threshold: 0 # Shouldn't remove coverage
2828
- type: patch
2929
target: 50 # Language specific featues must be 100% covered
30+
flags:
31+
- unit-tests
3032
- component_id: codegen-sdk-core
3133
name: codegen-sdk-core
3234
paths:
3335
- src/codegen/sdk/**
36+
flags:
37+
- unit-tests
3438

3539
flag_management:
3640
default_rules:

.github/workflows/unit-tests.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ on:
1212

1313
jobs:
1414
unit-tests:
15-
runs-on: ubuntu-latest-16
15+
runs-on: ubuntu-latest-8
1616
steps:
1717
- uses: actions/checkout@v4
1818
with:

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -184,7 +184,7 @@ pythonpath = "."
184184
norecursedirs = "repos expected"
185185
# addopts = -v --cov=app --cov-report=term
186186

187-
addopts = "--dist=loadgroup --junitxml=build/test-results/test/TEST.xml --strict-config --import-mode=importlib --cov-context=test --cov-report=json --cov-config=pyproject.toml -p no:doctest"
187+
addopts = "--dist=loadgroup --junitxml=build/test-results/test/TEST.xml --strict-config --import-mode=importlib --cov-context=test --cov-config=pyproject.toml -p no:doctest"
188188
filterwarnings = """
189189
ignore::DeprecationWarning:botocore.*:
190190
ignore::DeprecationWarning:sqlalchemy.*:

src/codegen/sdk/core/import_resolution.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
from abc import abstractmethod
44
from dataclasses import dataclass
5-
from typing import TYPE_CHECKING, Generic, Literal, Self, TypeVar, override
5+
from typing import TYPE_CHECKING, ClassVar, Generic, Literal, Self, TypeVar, override
66

77
from codegen.sdk.codebase.resolution_stack import ResolutionStack
88
from codegen.sdk.codebase.transactions import TransactionPriority
@@ -76,7 +76,7 @@ class Import(Usable[ImportStatement], Chainable, Generic[TSourceFile], HasAttrib
7676
module: Editable | None
7777
symbol_name: Editable | None
7878
alias: Editable | None
79-
node_type: Literal[NodeType.IMPORT] = NodeType.IMPORT
79+
node_type: ClassVar[Literal[NodeType.IMPORT]] = NodeType.IMPORT
8080
import_type: ImportType
8181
import_statement: ImportStatement
8282

0 commit comments

Comments
 (0)